Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose system component ports to the cluster #358

Closed
wants to merge 1 commit into from
Closed

Expose system component ports to the cluster #358

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions cloud/vsphere/templates.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,6 +319,12 @@ kind: MasterConfiguration
api:
advertiseAddress: ${PUBLICIP}
bindPort: ${PORT}
etcd:
extraArgs:
listen-client-urls: http://0.0.0.0:2379
kubeProxy:
config:
metricsBindAddress: 0.0.0.0:10249
networking:
serviceSubnet: ${SERVICE_CIDR}
podSubnet: ${POD_CIDR}
Expand Down
9 changes: 9 additions & 0 deletions clusterctl/examples/google/provider-components.yaml.template
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,6 +252,12 @@ data:
api:
advertiseAddress: ${PUBLICIP}
bindPort: ${PORT}
etcd:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update clusterctl/examples/vsphere/provider-components.yaml.template as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no analogous MasterConfiguration there. For vSphere, this is configured in cloud/vshpere/templates.go (hardcoded in the machine controller image). In this PR I edit this file as well. Long term I think it would be useful to have a consistency, although I don't have a full context - it was probably implemented differently for a reason.

extraArgs:
listen-client-urls: http://0.0.0.0:2379
kubeProxy:
config:
metricsBindAddress: 0.0.0.0:10249
networking:
serviceSubnet: ${SERVICE_CIDR}
kubernetesVersion: v${CONTROL_PLANE_VERSION}
Expand All @@ -261,6 +267,9 @@ data:
cluster-cidr: ${POD_CIDR}
service-cluster-ip-range: ${SERVICE_CIDR}
allocate-node-cidrs: "true"
address: 0.0.0.0
schedulerExtraArgs:
address: 0.0.0.0
apiServerCertSANs:
- ${PUBLICIP}
- ${PRIVATEIP}
Expand Down
6 changes: 6 additions & 0 deletions gcp-deployer/machine_setup_configs.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,12 @@ items:
api:
advertiseAddress: ${PUBLICIP}
bindPort: ${PORT}
etcd:
extraArgs:
listen-client-urls: http://0.0.0.0:2379
kubeProxy:
config:
metricsBindAddress: 0.0.0.0:10249
networking:
serviceSubnet: ${SERVICE_CIDR}
kubernetesVersion: v${CONTROL_PLANE_VERSION}
Expand Down