Change the reconcile logic to include machines being deleted #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the logic from not counting machines that are being deleted towards the machineset replica to counting them. The reason for the change is that due to machine deletion taking non-trivial amount of time, machine deployment rolling update may exceed the expected number of machines utilized. For example, for a machine set with 3 replicas and max surge 1, for a max of 4 machines. - create new machine in new machineset (4 machines) - once new machine is ready, delete a machine from old machineset (4 machines, as machine is still being deleted) - create new machine as deleted machine is not counted (5 machines) For the duration of the old machine being deleted, we would exceed the number of machines by 1.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: k4leung4 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
|
/assign @krousey @jessicaochen |
|
lgtm (leaving backslash for second reviewer) |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
jayunit100
pushed a commit
to jayunit100/cluster-api
that referenced
this pull request
Jan 31, 2020
Fixes failed JSON patches
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This changes the logic from not counting machines that are being deleted
towards the machineset replica to counting them. The reason for the
change is that due to machine deletion taking non-trivial amount of
time, machine deployment rolling update may exceed the expected number
of machines utilized.
For example, for a machine set with 3 replicas and max surge 1, for a
max of 4 machines.
For the duration of the old machine being deleted, we would exceed the
number of machines by 1.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #340
Special notes for your reviewer:
Release note:
@kubernetes/kube-deploy-reviewers