🐛 Delete ClusterResourceSetBinding when cluster is deleted. #3366
+149
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/M
sedefsavas
commented
Jul 17, 2020
k8s-ci-robot
added
the
do-not-merge/hold
ncdc
reviewed
Jul 17, 2020
sedefsavas
force-pushed
the
binding_cleanup
branch
from
e3dfa04 to
dfda927
Compare
k8s-ci-robot
added
size/L
ncdc
reviewed
Jul 21, 2020
vincepri
reviewed
Jul 21, 2020
ncdc
reviewed
Jul 23, 2020
detiber
reviewed
Jul 23, 2020
sedefsavas
force-pushed
the
binding_cleanup
branch
2 times, most recently
from
4f2c893 to
72a2f78
Compare
detiber
reviewed
Jul 23, 2020
|
/lgtm |
k8s-ci-robot
added
the
lgtm
ncdc
reviewed
Jul 23, 2020
|
/test pull-cluster-api-e2e |
sedefsavas
force-pushed
the
binding_cleanup
branch
from
e86cfeb to
352c21b
Compare
k8s-ci-robot
removed
the
lgtm
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ncdc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
Just holding until e2e tests pass. |
|
/hold cancel |
1 similar comment
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR deletes ClusterResourceSetBinding when the owner cluster is deleted.
This is not garbage collected because both Cluster and ClusterResourceSet are the owners of ClusterResourceSetBinding but when any of them is deleted, ClusterResourceSetBinding should also be deleted.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #3357