📖 Update CAPZ quickstart variables to include new AZURE_JSON_B64 secret #3303
Conversation
k8s-ci-robot
added
do-not-merge/hold
k8s-ci-robot
added
the
size/S
k8s-ci-robot
requested review from
alexeldeib,
nader-ziada,
JoelSpeed and
vincepri
CecileRobertMichon
changed the title
| "maximumLoadBalancerRuleCount": 250, | ||
| "useManagedIdentityExtension": false, | ||
| "useInstanceMetadata": true | ||
| }" | base64 | tr -d '\r\n') |
There was a problem hiding this comment.
note that I removed the envsubst command because it isn't a pre-requisite for the quickstart. I believe this is equivalent, but correct me if I'm wrong @alexeldeib.
There was a problem hiding this comment.
tested that and can confirm its the same
k8s-ci-robot
added
the
lgtm
|
/test pull-cluster-api-e2e |
|
@CecileRobertMichon ready to merge this? |
|
@vincepri not yet, holding until CAPZ release (with new templates) |
k8s-ci-robot
removed
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CecileRobertMichon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
What this PR does / why we need it: Following up on kubernetes-sigs/cluster-api-provider-azure#653, we need to update the quickstart to include the new secret var.
/hold until CAPZ v0.4.6 release
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #