Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 MachinePool now has status.observedGeneration #3266

Merged
merged 1 commit into from
Jun 30, 2020
Merged

🌱 MachinePool now has status.observedGeneration #3266

merged 1 commit into from
Jun 30, 2020

Conversation

spagno
Copy link
Contributor

@spagno spagno commented Jun 26, 2020 •
edited
Loading

What this PR does / why we need it:
Add the status ObserverGeneration into the machinepool controller
Which issue(s) this PR fixes:
Fixes #3078

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 26, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @spagno. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 26, 2020
@spagno spagno force-pushed the add-observedgeneration-to-machinepool branch from 6fc0e58 to 4b21e79 Compare June 26, 2020 20:17
@spagno spagno force-pushed the add-observedgeneration-to-machinepool branch from 4b21e79 to 4987435 Compare June 30, 2020 04:44
@fabriziopandini
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 30, 2020
@spagno
Copy link
Contributor Author

spagno commented Jun 30, 2020

/test pull-cluster-api-e2e

@fabriziopandini
Copy link
Member

@spagno

generated files are out of date, run make generate

@spagno spagno force-pushed the add-observedgeneration-to-machinepool branch from 4987435 to f08a696 Compare June 30, 2020 09:18
@fabriziopandini
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 30, 2020
vincepri
vincepri approved these changes Jun 30, 2020
View reviewed changes
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/milestone v0.3.7
/retitle 🌱 MachinePool now has status.observedGeneration

@k8s-ci-robot k8s-ci-robot changed the title ✨ Add ObservedGeneration to MachinePool Controller 🌱 MachinePool now has status.observedGeneration Jun 30, 2020
@k8s-ci-robot k8s-ci-robot added this to the v0.3.7 milestone Jun 30, 2020
@vincepri
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 30, 2020
@k8s-ci-robot k8s-ci-robot merged commit 3ac7114 into kubernetes-sigs:master Jun 30, 2020
@spagno spagno deleted the add-observedgeneration-to-machinepool branch July 7, 2020 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabriziopandini fabriziopandini fabriziopandini left review comments

@detiber detiber detiber left review comments

@vincepri vincepri vincepri approved these changes

@benmoss benmoss Awaiting requested review from benmoss

@CecileRobertMichon CecileRobertMichon Awaiting requested review from CecileRobertMichon

Assignees

@fabriziopandini fabriziopandini

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v0.3.7
Development

Successfully merging this pull request may close these issues.

Add .status.observedGeneration to all objects
5 participants
@spagno @k8s-ci-robot @fabriziopandini @vincepri @detiber