test framework: Enable metrics collection #3262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/M
randomvariable
force-pushed
the
capture-metrics
branch
2 times, most recently
from
46879ed to
4d810b4
Compare
k8s-ci-robot
added
size/L
randomvariable
force-pushed
the
capture-metrics
branch
4 times, most recently
from
c7517d5 to
1475c22
Compare
Signed-off-by: Naadir Jeewa <[email protected]>
randomvariable
force-pushed
the
capture-metrics
branch
from
1475c22 to
f429fb5
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/milestone v0.3.7 |
fabriziopandini
approved these changes
Jun 26, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
As part of investigating kubernetes-sigs/cluster-api-provider-aws#1764, found it useful to collect metrics during an e2e test. PR'ing the bits that I've used.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #