-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Allow incremental condition patch #3261
🌱 Allow incremental condition patch #3261
Conversation
c704c98
to
d668e5b
Compare
As a reminder pull-cluster-api-apidiff output
Above changes are ok because those methods where not part of a release (they were included in v0.3.7 alpha 0, but this is fine) |
/milestone v0.3.7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/assign @detiber
/assign @ncdc for final approval |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes. just minor nits
ea7b0e0
to
2fb80bf
Compare
@gab-satchi comment addressed, PTAL |
@fabriziopandini: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
This PR allows incremental condition patching within the same controller.
In order to do so, in the final defer patch, it is required to declare the list of conditions the controller owns, and for which, a conflict between after and latest value of the condition should not generate errors (after value should always be used instead)
Which issue(s) this PR fixes:
Fixes #3260
/assign @vincepri
/assign @gab-satchi