Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vsphere README for machineset #326

Merged
merged 1 commit into from
Jun 11, 2018

Conversation

karan
Copy link
Contributor

@karan karan commented Jun 11, 2018

Title

/assign @roberthbailey

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 11, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: karan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 11, 2018
@roberthbailey
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 11, 2018
@karan
Copy link
Contributor Author

karan commented Jun 11, 2018

/retest

@k8s-ci-robot k8s-ci-robot merged commit fbc85d9 into kubernetes-sigs:master Jun 11, 2018
@karan karan deleted the vsphere-readme branch June 11, 2018 18:51
jayunit100 pushed a commit to jayunit100/cluster-api that referenced this pull request Jan 31, 2020
jayunit100 pushed a commit to jayunit100/cluster-api that referenced this pull request Jan 31, 2020
…er-schedule-on-master

clusterctl: vsphere provider manager should only run on control plane nodes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants