Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] 🌱 Clusterctl move Cluster Principal #3254

Conversation

fabriziopandini
Copy link
Member

What this PR does / why we need it:
This PR extends clusterctl move so it will manage to move the cluster principal objects introduced for addressing CAPA multitenancy (kubernetes-sigs/cluster-api-provider-aws#1753).
NB. the implementation is generic, so it will work for any infrastructure provider implementing a similar solution.

NB.
this PR will remain WIP until kubernetes-sigs/cluster-api-provider-aws#1753 merges

Which issue(s) this PR fixes:
Fixes #3081

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 25, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign fabriziopandini
You can assign the PR to them by writing /assign @fabriziopandini in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fabriziopandini
Copy link
Member Author

/assing @randomvariable
/assing @vincepri

@vincepri
Copy link
Member

/milestone v0.3.x

Going to hold this until after v0.3.7 is cut

@k8s-ci-robot k8s-ci-robot added this to the v0.3.x milestone Jun 25, 2020
@fabriziopandini
Copy link
Member Author

/test pull-cluster-api-test

@CecileRobertMichon
Copy link
Contributor

NB. the implementation is generic, so it will work for any infrastructure provider implementing a similar solution.

Can we document this in https://cluster-api.sigs.k8s.io/clusterctl/provider-contract.html ?

@fabriziopandini
Copy link
Member Author

Can we document this in https://cluster-api.sigs.k8s.io/clusterctl/provider-contract.html

Sure. I have a PR ready with the documentation for the three clusterctl PRs I have in flight

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 7, 2020
@k8s-ci-robot
Copy link
Contributor

@fabriziopandini: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@fabriziopandini
Copy link
Member Author

@randomvariable is there any ETA about the proposal for Cluster Principal in CAPA, so I can properly prioritize this work?

@randomvariable
Copy link
Member

@fabriziopandini Proposal is in, implementation is in some part of the 0.5.x series, not the 0.5.5 that is currently in the process of being released.

@vincepri
Copy link
Member

vincepri commented Aug 3, 2020

/milestone v0.4.0

@k8s-ci-robot k8s-ci-robot modified the milestones: v0.3.x, v0.4.0 Aug 3, 2020
@vincepri
Copy link
Member

vincepri commented Sep 2, 2020

@fabriziopandini Can this be closed?

@fabriziopandini
Copy link
Member Author

/close
We can reopen once the changes lands on CAPA
@randomvariable ^^

@k8s-ci-robot
Copy link
Contributor

@fabriziopandini: Closed this PR.

In response to this:

/close
We can reopen once the changes lands on CAPA
@randomvariable ^^

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@fabriziopandini fabriziopandini deleted the move-ClusterPrincipal branch September 3, 2020 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

clusterctl move support for cluster-scoped global resources
5 participants