-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] 🌱 Clusterctl move Cluster Principal #3254
[WIP] 🌱 Clusterctl move Cluster Principal #3254
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/assing @randomvariable |
/milestone v0.3.x Going to hold this until after v0.3.7 is cut |
/test pull-cluster-api-test |
Can we document this in https://cluster-api.sigs.k8s.io/clusterctl/provider-contract.html ? |
Sure. I have a PR ready with the documentation for the three clusterctl PRs I have in flight |
@fabriziopandini: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@randomvariable is there any ETA about the proposal for Cluster Principal in CAPA, so I can properly prioritize this work? |
@fabriziopandini Proposal is in, implementation is in some part of the 0.5.x series, not the 0.5.5 that is currently in the process of being released. |
/milestone v0.4.0 |
@fabriziopandini Can this be closed? |
/close |
@fabriziopandini: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
This PR extends
clusterctl move
so it will manage to move the cluster principal objects introduced for addressing CAPA multitenancy (kubernetes-sigs/cluster-api-provider-aws#1753).NB. the implementation is generic, so it will work for any infrastructure provider implementing a similar solution.
NB.
this PR will remain WIP until kubernetes-sigs/cluster-api-provider-aws#1753 merges
Which issue(s) this PR fixes:
Fixes #3081