Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Image builds should prepull experimental docker buildkit deps #3235

Merged

Conversation

fabriziopandini
Copy link
Member

What this PR does / why we need it:
this is a tentative to fix image build in CI

/assing @detiber
/assing @vincepri

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 23, 2020
@k8s-ci-robot k8s-ci-robot requested review from benmoss and vincepri June 23, 2020 18:43
Makefile Outdated Show resolved Hide resolved
@fabriziopandini fabriziopandini force-pushed the fix-image-build branch 2 times, most recently from 6762f05 to 9ba2cbd Compare June 23, 2020 18:50
Makefile Outdated Show resolved Hide resolved
@detiber
Copy link
Member

detiber commented Jun 23, 2020

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 23, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: detiber

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 23, 2020
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/milestone v0.3.7
/retitle 🌱 Image builds should prepull experimental docker buildkit deps

@k8s-ci-robot k8s-ci-robot added this to the v0.3.7 milestone Jun 23, 2020
@k8s-ci-robot k8s-ci-robot changed the title 🌱 fix image build 🌱 Image builds should prepull experimental docker buildkit deps Jun 23, 2020
@k8s-ci-robot k8s-ci-robot merged commit 241d247 into kubernetes-sigs:master Jun 23, 2020
@fabriziopandini fabriziopandini deleted the fix-image-build branch June 29, 2020 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants