Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Adds a test for ensureNamespaces (plural) #3224

Merged
merged 1 commit into from
Jun 22, 2020
Merged

🌱 Adds a test for ensureNamespaces (plural) #3224

merged 1 commit into from
Jun 22, 2020

Conversation

hazbo
Copy link
Contributor

@hazbo hazbo commented Jun 20, 2020

Following my recent work on fixing a small bug and writing tests for
ensureNamespace in #3217 in order to close #2252

What this PR does / why we need it:
A few test cases have been added to ensure namespaces are created on a target before other objects are moved across.

Which issue(s) this PR fixes:
Fixes #2252
This was closed I think in some confusion with my previous test which was ensureNamespace (no S).

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 20, 2020
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 20, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @hazbo. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 20, 2020
@hazbo
Adds a test for ensureNamespaces
132537e 
Following my recent work on fixing a small bug and writing tests for
`ensureNamespace`.

Adds a test for ensureNamespaces

Following my recent work on fixing a small bug and writing tests for
`ensureNamespace`.

Typo
@hazbo hazbo force-pushed the test-ensureNamespaces-works branch from 844a8d2 to 132537e Compare June 20, 2020 14:29
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 20, 2020
@hazbo
Copy link
Contributor Author

hazbo commented Jun 20, 2020

/assign @ncdc

@hazbo hazbo mentioned this pull request Jun 20, 2020
Merged
@fabriziopandini
Copy link
Member

/close
Closed by #3217

@k8s-ci-robot
Copy link
Contributor

@fabriziopandini: Closed this PR.

In response to this:

/close
Closed by #3217

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hazbo
Copy link
Contributor Author

hazbo commented Jun 22, 2020 •
edited
Loading

@fabriziopandini I'm unsure why this was closed. Does this code not require test coverage?

#3217 tests a different function

@fabriziopandini
Copy link
Member

Ohh, you are right, I missed the plural part (note for self: drink more coffee on Monday 😉 )
/reopen

@k8s-ci-robot k8s-ci-robot reopened this Jun 22, 2020
@k8s-ci-robot
Copy link
Contributor

@fabriziopandini: Reopened this PR.

In response to this:

Ohh, you are right, I missed the plural part (note for self: drink more coffee on Monday 😉 )
/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@fabriziopandini
Copy link
Member

/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 22, 2020
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 22, 2020
@hazbo
Copy link
Contributor Author

hazbo commented Jun 22, 2020

/retest

vincepri
vincepri approved these changes Jun 22, 2020
View reviewed changes
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/milestone v0.3.7
/approve

@k8s-ci-robot k8s-ci-robot added this to the v0.3.7 milestone Jun 22, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 22, 2020
@k8s-ci-robot k8s-ci-robot merged commit 0e9f5a8 into kubernetes-sigs:master Jun 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincepri vincepri vincepri approved these changes

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

@wfernandes wfernandes Awaiting requested review from wfernandes

Assignees

@ncdc ncdc

@fabriziopandini fabriziopandini

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v0.3.7
Development

Successfully merging this pull request may close these issues.

[clusterctl] add unit tests for ensureNamespaces
5 participants
@hazbo @k8s-ci-robot @fabriziopandini @vincepri @ncdc