🌱 Rewrite MHC tests to be consistent with rest of codebase

[vincepri]

Signed-off-by: Vince Prignano [email protected]

What this PR does / why we need it:

This PR rewrites the MHC tests to be consistent with the rest of the codebase, it makes sure that we don't reuse any objects between specs. The code can be improved, for example the generation of the fake and nodes could take a struct instead of arguments; but we can tackle this later. The main goal is to get rid of the flakes and clean this up.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #3197

[vincepri]

Forgot to add 10s timeouts, fixed now

[vincepri]

/test pull-cluster-api-test

[vincepri]

/test pull-cluster-api-test

[vincepri]

Alright,

[vincepri]

/milestone v0.3.7

[vincepri]

/assign @randomvariable @fabriziopandini

[randomvariable]

/lgtm

[vincepri]

@detiber
for approval

[detiber]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: detiber

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [detiber]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

@vincepri: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
pull-cluster-api-e2e	e6161ff	link	/test pull-cluster-api-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[vincepri]

/test pull-cluster-api-e2e