Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 listDescendents fetch MachinePools #3196

Merged
merged 2 commits into from
Jul 9, 2020
Merged

🐛 listDescendents fetch MachinePools #3196

merged 2 commits into from
Jul 9, 2020

Conversation

prankul88
Copy link
Contributor

@prankul88 prankul88 commented Jun 16, 2020 •
edited
Loading

What this PR does / why we need it:
This PR makes surelistDescendents function fetches MachinePools object too. This enables MachinePools to be deleted as well when cluster is deleted.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #2952

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 16, 2020
@k8s-ci-robot k8s-ci-robot requested review from ncdc and vincepri June 16, 2020 12:39
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 16, 2020
detiber
detiber reviewed Jun 16, 2020
View reviewed changes
Copy link
Member

@detiber detiber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@prankul88 thanks for tackling this, the underlying changes look good to me, I think it just needs a bit of wrapping with checks to see if the feature gate is enabled.

controllers/cluster_controller.go Outdated Show resolved Hide resolved
controllers/cluster_controller.go Outdated Show resolved Hide resolved
controllers/cluster_controller.go Outdated Show resolved Hide resolved
@vincepri
Copy link
Member

Also needs to add some tests

@prankul88 prankul88 force-pushed the listDescendents-update branch from 24e1a86 to 05dd3e3 Compare June 18, 2020 08:25
@prankul88
Copy link
Contributor Author

@detiber Enabled feature gate as you mentioned. Will be adding tests soon

@vincepri
Copy link
Member

@prankul88 Do you have time to follow-up with some tests? Should be ok to also open an issue and open a PR later.

@prankul88
Copy link
Contributor Author

@prankul88 Do you have time to follow-up with some tests? Should be ok to also open an issue and open a PR later.

@vincepri I am a little busy with another patch. Would be nice if we can open an issue for the tests. I can open an issue if you like

@vincepri
Copy link
Member

vincepri commented Jul 2, 2020

@prankul88 Thank you!

/approve
/assign @detiber
/milestone v0.3.7

@k8s-ci-robot k8s-ci-robot added this to the v0.3.7 milestone Jul 2, 2020
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 2, 2020
@prankul88 prankul88 mentioned this pull request Jul 7, 2020
Closed
@prankul88
Copy link
Contributor Author

@detiber @vincepri I have opened an issue #3294 to address tests for this. Thanks

@prankul88 prankul88 force-pushed the listDescendents-update branch from 05dd3e3 to 1d114a9 Compare July 8, 2020 11:05
@prankul88 prankul88 force-pushed the listDescendents-update branch from 1d114a9 to 5e5bcf0 Compare July 9, 2020 07:26
@prankul88
Copy link
Contributor Author

@vincepri PTAL

vincepri
vincepri approved these changes Jul 9, 2020
View reviewed changes
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/assign @CecileRobertMichon

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@CecileRobertMichon
Copy link
Contributor

lgtm besides typo

@vincepri
Copy link
Member

vincepri commented Jul 9, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 9, 2020
@vincepri
Copy link
Member

vincepri commented Jul 9, 2020

Fixed the typo by accepting @fabriziopandini's suggestion, to move things along for RC.1 :)

@k8s-ci-robot k8s-ci-robot merged commit 4c5249c into kubernetes-sigs:master Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabriziopandini fabriziopandini fabriziopandini left review comments

@detiber detiber detiber left review comments

@vincepri vincepri vincepri approved these changes

@ncdc ncdc Awaiting requested review from ncdc

Assignees

@detiber detiber

@vincepri vincepri

@CecileRobertMichon CecileRobertMichon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v0.3.7
Development

Successfully merging this pull request may close these issues.

listDescendants should also fetch machinepools
6 participants
@prankul88 @vincepri @k8s-ci-robot @CecileRobertMichon @detiber @fabriziopandini