-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Apply conditions patch should preserve LastTransitionTime #3179
🐛 Apply conditions patch should preserve LastTransitionTime #3179
Conversation
/assign @benmoss |
Great branch name 😄 |
Looks like it's not flaky anymore too 😸 . I'll try to make a patch to fix it if I can figure it out. |
This is one solution to fixing this test now: https://gist.github.com/benmoss/14ac414bccdfbce903ee4db43da7f18b go-cmp will end up using https://golang.org/pkg/time/#Time.Equal rather than Gomega's |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 for the name changes in patch.go, much clearer this way I think
88f233b
to
bb93a8a
Compare
/retest |
1 similar comment
/retest |
a690b64
to
2b50149
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/milestone v0.3.7
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini, vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
What this PR does / why we need it:
This PR fixes a nasty bug when applying a condition patch with and add operation with the path happening on a different second than the one where the condition was set on the target object.
The PR also align the variable names used for the objects involved in the three-way merge with the one used by the patch helper (before, after, latest), so there will be less confusion were looking at the code
Which issue(s) this PR fixes
Fixes #3178