-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Fix support for dual-stack network ranges #3172
🐛 Fix support for dual-stack network ranges #3172
Conversation
12ff5cb
to
3ab0163
Compare
3ab0163
to
f708cc8
Compare
cc @sethp-nr since you just worked on this part of the codebase |
lgtm pending running make manifests to fix CI errors |
I looked at doing validation using the function that Kubeadm uses but 1) we'd have to copy/pasta it, and 2) it's a lot harder for us to get all the information needed in one place. It'd have to end up being a reconciliation failure as far as I can think of, rather than a CRD validation. |
f708cc8
to
7638263
Compare
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/milestone v0.3.7
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: benmoss, vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Fixes support for dual-stack network ranges. Users can provide more than one pod and/or service CIDR block on their ClusterSpec's ClusterNetwork struct which then is used to populate the KubeadmConfig Networking struct.
Which issue(s) this PR fixes
Fixes #3149