Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📖 added packet where needed across the cluster-api #3123

Merged
merged 1 commit into from
Jun 4, 2020
Merged

📖 added packet where needed across the cluster-api #3123

merged 1 commit into from
Jun 4, 2020

Conversation

gianarb
Copy link

@gianarb gianarb commented Jun 1, 2020 •
edited
Loading

The Packet provider was missed from a small number of pages in the
documentation.

/cc. @deitch

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 1, 2020
@k8s-ci-robot
Copy link
Contributor

Welcome @gianarb!

It looks like this is your first PR to kubernetes-sigs/cluster-api 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @gianarb. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 1, 2020
@fabriziopandini
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 1, 2020
@fabriziopandini
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini, gianarb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 1, 2020
fabriziopandini
fabriziopandini reviewed Jun 1, 2020
View reviewed changes
docs/book/src/user/quick-start.md
@@ -228,6 +228,11 @@ clusterctl init --infrastructure openstack

Please visit the [Metal3 project][Metal3 getting started guide].

{{#/tab }}
{{#tab Packet}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Packet should be added to the list of tabs at line 130

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can I change it now? Because you approved it, not sure if that will drive the automation crazy or not

@fabriziopandini
Copy link
Member

@vincepri this one is ready to go for me
over to you

@gianarb gianarb changed the title docs: added packet where needed across the cluster-api 📖 📖 added packet where needed across the cluster-api Jun 1, 2020
CecileRobertMichon
CecileRobertMichon reviewed Jun 1, 2020
View reviewed changes
docs/book/src/clusterctl/provider-contract.md
@@ -174,6 +174,7 @@ providers.
|CAPD | cluster.x-k8s.io/provider=infrastructure-docker |
|CAPM3 | cluster.x-k8s.io/provider=infrastructure-metal3 |
|CAPZ | cluster.x-k8s.io/provider=infrastructure-azure |
|CAPP | cluster.x-k8s.io/provider=infrastructure-packet |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be in alphabetical order

CecileRobertMichon
CecileRobertMichon reviewed Jun 1, 2020
View reviewed changes
docs/book/src/user/quick-start.md
@@ -228,6 +228,11 @@ clusterctl init --infrastructure openstack

Please visit the [Metal3 project][Metal3 getting started guide].

{{#/tab }}
{{#tab Packet}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does Packet also need to be added to line 491 (CNI instructions) https://github.com/kubernetes-sigs/cluster-api/pull/3123/files#diff-dccb64095f5c5a09d32f119446301d12L486?

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 3, 2020
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 3, 2020
@gianarb
Copy link
Author

gianarb commented Jun 4, 2020

@CecileRobertMichon can you have another look?
Thanks a lot

@vincepri
Copy link
Member

vincepri commented Jun 4, 2020

Friendly reminder to rebase before merging 😄

@gianarb
Copy link
Author

gianarb commented Jun 4, 2020

@vincepri done!

@vincepri
Copy link
Member

vincepri commented Jun 4, 2020

@gianarb we usually have 1 commit, if all the changes are part of the same patchset

docs: added packet where needed across the cluster-api doc
617783e 
The Packet provider was missed from a small amount of pages in the
documentation.
@gianarb
Copy link
Author

gianarb commented Jun 4, 2020

@vincepri I have squashed my commits

@vincepri
Copy link
Member

vincepri commented Jun 4, 2020

Changes LGTM, over to you @CecileRobertMichon for a final look

@CecileRobertMichon
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 4, 2020
@k8s-ci-robot k8s-ci-robot merged commit abd2eae into kubernetes-sigs:master Jun 4, 2020
@fabriziopandini fabriziopandini mentioned this pull request Jun 30, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabriziopandini fabriziopandini fabriziopandini left review comments

@benmoss benmoss Awaiting requested review from benmoss

@CecileRobertMichon CecileRobertMichon Awaiting requested review from CecileRobertMichon

Assignees

@CecileRobertMichon CecileRobertMichon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gianarb @k8s-ci-robot @fabriziopandini @vincepri @CecileRobertMichon