📖 Update quickstart for clusterawsadm v2 #3116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/hold
k8s-ci-robot
added
the
size/XS
|
/test pull-cluster-api-test |
detiber
reviewed
Jun 1, 2020
vincepri
changed the title
|
@randomvariable Can this be merged now? The linked PR has been merged a while ago |
|
@vincepri Not yet, there's no release of that version of clusterawsadm yet. Also, let me add the version bits now. |
randomvariable
force-pushed
the
clusterawsadmv2-docs
branch
from
9a1a93c to
a575ad4
Compare
detiber
reviewed
Jun 23, 2020
Signed-off-by: Naadir Jeewa <[email protected]>
randomvariable
force-pushed
the
clusterawsadmv2-docs
branch
from
a575ad4 to
f0193ae
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
vincepri
approved these changes
Jun 23, 2020
k8s-ci-robot
removed
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
@vincepri the referenced minimum version needed for cluster-api-provider-aws does not currently exist yet. Should this be reverted until it does? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/hold
What this PR does / why we need it:
Updates quick start docs to match kubernetes-sigs/cluster-api-provider-aws#1734
To be merged after CAPA v0.5.5 is released.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #