✨ add condition merge utils #3103
Conversation
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
| conditions := from.GetConditions() | ||
|
|
||
| conditionsInScope := make([]localizedCondition, 0, len(conditions)) | ||
| for i := range conditions { |
There was a problem hiding this comment.
can be for i, c := range conditions {
There was a problem hiding this comment.
unfortunately not, because we are using &c down in the loop and the linter complains for:
Using a reference for the variable on range scope c``
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
I had comments on this PR but didn't make it in time, also we forgot to squash |
|
@vincepri I'm happy to pick up your comments and address in a new PR. |
What this PR does / why we need it:
This PR implements a utils for handling conditions according to the design patterns introduced by the condition CAEP (Mirror, Aggregate, Summarize)
/cc @gab-satchi