Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Add condition types #3087

Merged
merged 1 commit into from
May 22, 2020
Merged

✨ Add condition types #3087

merged 1 commit into from
May 22, 2020

Conversation

fabriziopandini
Copy link
Member

What this PR does / why we need it:
This PR implements the types defined in the condition CAEP

/area api

@k8s-ci-robot k8s-ci-robot added area/api Issues or PRs related to the APIs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 22, 2020
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 22, 2020
@fabriziopandini
Copy link
Member Author

/cc @benmoss

@k8s-ci-robot k8s-ci-robot requested a review from benmoss May 22, 2020 15:24
vincepri
vincepri approved these changes May 22, 2020
View reviewed changes
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments, rest LGTM

/approve
/milestone v0.3.7

api/v1alpha3/condition_types.go Outdated Show resolved Hide resolved
api/v1alpha3/condition_types.go Outdated Show resolved Hide resolved
api/v1alpha3/condition_types.go Outdated Show resolved Hide resolved
api/v1alpha3/condition_types.go Outdated Show resolved Hide resolved
api/v1alpha3/condition_types.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added this to the v0.3.7 milestone May 22, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini, vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [fabriziopandini,vincepri]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vincepri
Copy link
Member

LGTM pending squash

It's happening 🎉 🎉 🎉 🎉

@fabriziopandini
Copy link
Member Author

squash!

@sedefsavas
Copy link

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 22, 2020
@k8s-ci-robot k8s-ci-robot merged commit f504874 into kubernetes-sigs:master May 22, 2020
@fabriziopandini fabriziopandini deleted the add-condition-types branch May 24, 2020 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sedefsavas sedefsavas sedefsavas left review comments

@vincepri vincepri vincepri approved these changes

@CecileRobertMichon CecileRobertMichon Awaiting requested review from CecileRobertMichon

@benmoss benmoss Awaiting requested review from benmoss

Assignees

@sedefsavas sedefsavas

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/api Issues or PRs related to the APIs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v0.3.7
Development

Successfully merging this pull request may close these issues.
4 participants
@fabriziopandini @k8s-ci-robot @vincepri @sedefsavas