🐛 Ignore custom static manifests on kubeadm join #3053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Naadir Jeewa <[email protected]>
k8s-ci-robot
added
cncf-cla: yes
JoelSpeed
reviewed
May 12, 2020
|
IIRC we're not running the e2e with the experimental flag — did we run at least one manual test with a provider? |
|
I did it manually via CAPV, but happy to add an e2e test. Right now, the only time we're doing a HA control plane is in the upgrade test. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: randomvariable, vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
fabriziopandini
approved these changes
May 12, 2020
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
During experimental join retries, specifically ignore the
/etc/kubernetes/manifestsdirectory, which will allow the addition of custom static pod manifests, which is required for some Kubernetes cluster configurations, such as external KMS.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #3019