Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖CAEP: Cluster Resource Set #3050

Merged

Conversation

sedefsavas
Copy link

What this PR does / why we need it:
This PR adds CAEP for implementing Cluster Resource Set that was discussed in Design Doc.

Moving here for getting feedback from a broader audience.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 11, 2020
@k8s-ci-robot k8s-ci-robot requested review from detiber and ncdc May 11, 2020 21:49
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 11, 2020
@sedefsavas
Copy link
Author

/cc @vincepri @timothysc @fabriziopandini
/kind proposal

I am starting a lazy consensus period ending on May 19th.

docs/proposals/20200220-cluster-resource-set.md Outdated Show resolved Hide resolved
docs/proposals/20200220-cluster-resource-set.md Outdated Show resolved Hide resolved
docs/proposals/20200220-cluster-resource-set.md Outdated Show resolved Hide resolved
docs/proposals/20200220-cluster-resource-set.md Outdated Show resolved Hide resolved
docs/proposals/20200220-cluster-resource-set.md Outdated Show resolved Hide resolved
docs/proposals/20200220-cluster-resource-set.md Outdated Show resolved Hide resolved
docs/proposals/20200220-cluster-resource-set.md Outdated Show resolved Hide resolved
docs/proposals/20200220-cluster-resource-set.md Outdated Show resolved Hide resolved
docs/proposals/20200220-cluster-resource-set.md Outdated Show resolved Hide resolved
@sedefsavas sedefsavas force-pushed the caep-clusterresourceset branch 4 times, most recently from ca60967 to 482fdd6 Compare May 13, 2020 20:38
docs/proposals/20200220-cluster-resource-set.md Outdated Show resolved Hide resolved
docs/proposals/20200220-cluster-resource-set.md Outdated Show resolved Hide resolved
docs/proposals/20200220-cluster-resource-set.md Outdated Show resolved Hide resolved
docs/proposals/20200220-cluster-resource-set.md Outdated Show resolved Hide resolved
docs/proposals/20200220-cluster-resource-set.md Outdated Show resolved Hide resolved
docs/proposals/20200220-cluster-resource-set.md Outdated Show resolved Hide resolved
docs/proposals/20200220-cluster-resource-set.md Outdated Show resolved Hide resolved
@vincepri
Copy link
Member

/milestone v0.3.x

@k8s-ci-robot k8s-ci-robot added this to the v0.3.x milestone May 14, 2020
@sedefsavas sedefsavas force-pushed the caep-clusterresourceset branch from 482fdd6 to 76043c5 Compare May 15, 2020 04:43
@sedefsavas sedefsavas force-pushed the caep-clusterresourceset branch from 76043c5 to b15c870 Compare May 15, 2020 04:53
docs/proposals/20200220-cluster-resource-set.md Outdated Show resolved Hide resolved
docs/proposals/20200220-cluster-resource-set.md Outdated Show resolved Hide resolved
docs/proposals/20200220-cluster-resource-set.md Outdated Show resolved Hide resolved
docs/proposals/20200220-cluster-resource-set.md Outdated Show resolved Hide resolved
@sedefsavas sedefsavas force-pushed the caep-clusterresourceset branch from a5962f5 to 6c98f6d Compare May 26, 2020 19:08
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm +1 to see this proposal implemented with the namespace restrictions for ClusterResourceSet & the ClusterResourceSetStatus as a separate CRD. This will help to get clusterctl move to manage the new resources..
I have left two suggestions WRT to the ClusterResourceSetStatus but they are optional and can be considered implementation details

docs/proposals/20200220-cluster-resource-set.md Outdated Show resolved Hide resolved
name: <cluster-name>
namespace: <cluster-namespace>
spec:
clusterresourcesets:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this can be simplified by having a simple map of resources; this will also address cases when the same secret/configMap is part of more than one ResourceSet

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this may cause racing condition if two ClusterResourceSets have same resource and they need to change this from different controller threads. Wdyt?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that i two resource set have the same resource, the resource should be applied only once. In fact, this structure helps to implement this behavior

Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sedefsavas, vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 27, 2020
@detiber
Copy link
Member

detiber commented May 27, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 27, 2020
@k8s-ci-robot k8s-ci-robot merged commit 01ede5f into kubernetes-sigs:master May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/proposal Issues or PRs related to proposals. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants