-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📖CAEP: Cluster Resource Set #3050
📖CAEP: Cluster Resource Set #3050
Conversation
/cc @vincepri @timothysc @fabriziopandini I am starting a lazy consensus period ending on May 19th. |
ca60967
to
482fdd6
Compare
/milestone v0.3.x |
482fdd6
to
76043c5
Compare
76043c5
to
b15c870
Compare
d081921
to
a5962f5
Compare
a5962f5
to
6c98f6d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm +1 to see this proposal implemented with the namespace restrictions for ClusterResourceSet & the ClusterResourceSetStatus as a separate CRD. This will help to get clusterctl move to manage the new resources..
I have left two suggestions WRT to the ClusterResourceSetStatus but they are optional and can be considered implementation details
name: <cluster-name> | ||
namespace: <cluster-namespace> | ||
spec: | ||
clusterresourcesets: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this can be simplified by having a simple map of resources; this will also address cases when the same secret/configMap is part of more than one ResourceSet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this may cause racing condition if two ClusterResourceSets have same resource and they need to change this from different controller threads. Wdyt?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that i two resource set have the same resource, the resource should be applied only once. In fact, this structure helps to implement this behavior
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sedefsavas, vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
What this PR does / why we need it:
This PR adds CAEP for implementing Cluster Resource Set that was discussed in Design Doc.
Moving here for getting feedback from a broader audience.