-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[e2e] add machine helper for status check. #3028
[e2e] add machine helper for status check. #3028
Conversation
Waiting feedback from @gab-satchi about which checks are relevant here. |
@sedefsavas: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Hey @sedefsavas, the CAPA e2e testcase that prompted this issue was asserting that a machine reaches a 'Failed' state if the underlying infrastructure node is deleted. So the status check I'd need for that would be waiting for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sedefsavas
If I got it right what @gab-satchi is asking for, we need another status check (Status.Phase=Failed) and the possibility to check this and NodeRefAssignedStatus in and
5c19522
to
63b254b
Compare
63b254b
to
59ceb80
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
@gab-satchi for final lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini, sedefsavas The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retitle [e2e] add machine helper for status check. |
/lgtm |
What this PR does / why we need it:
This PR adds a machine status check helper.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #3016