Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[e2e] add machine helper for status check. #3028

Merged

Conversation

sedefsavas
Copy link

What this PR does / why we need it:
This PR adds a machine status check helper.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #3016

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 7, 2020
@k8s-ci-robot k8s-ci-robot requested review from justinsb and ncdc May 7, 2020 17:04
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 7, 2020
@sedefsavas
Copy link
Author

Waiting feedback from @gab-satchi about which checks are relevant here.

@k8s-ci-robot
Copy link
Contributor

@sedefsavas: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-cluster-api-capd-e2e 5c19522 link /test pull-cluster-api-capd-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@gab-satchi
Copy link
Member

Hey @sedefsavas, the CAPA e2e testcase that prompted this issue was asserting that a machine reaches a 'Failed' state if the underlying infrastructure node is deleted. So the status check I'd need for that would be waiting for Machine.Status.Phase to reach the state the test needs.

Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sedefsavas
If I got it right what @gab-satchi is asking for, we need another status check (Status.Phase=Failed) and the possibility to check this and NodeRefAssignedStatus in and

test/framework/machine_helpers.go Outdated Show resolved Hide resolved
@sedefsavas sedefsavas force-pushed the e2e-machine-status-check branch from 5c19522 to 63b254b Compare May 11, 2020 16:35
@sedefsavas sedefsavas force-pushed the e2e-machine-status-check branch from 63b254b to 59ceb80 Compare May 11, 2020 16:36
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
@gab-satchi for final lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini, sedefsavas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 11, 2020
@gab-satchi
Copy link
Member

/retitle [e2e] add machine helper for status check.

@k8s-ci-robot k8s-ci-robot changed the title 🏃[WIP] [e2e] add machine helper for status check. [e2e] add machine helper for status check. May 14, 2020
@gab-satchi
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 14, 2020
@k8s-ci-robot k8s-ci-robot merged commit 15300a4 into kubernetes-sigs:master May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

e2e Framework: Add machine helper to wait and validate status of machine
4 participants