🏃[e2e] Add machine deployment scaling helper function #3027
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/M
k8s-ci-robot
added
the
approved
|
/assign @gab-satchi |
|
@sedefsavas unrelated. There is s a bounce of upgrade failures that I can't nail down to a problem. Almost all of them happen in the cluster provisioning phase |
| machineSet := ms.Items[0] | ||
| selectorMap, err = metav1.LabelSelectorAsMap(&machineSet.Spec.Selector) | ||
| if err != nil { | ||
| return 0, err |
There was a problem hiding this comment.
Can the error states return -1 similar to what's done below on line 344. -1 is just more indicative of an error. Also, is there a reason for the function to even return the errors?
There was a problem hiding this comment.
Right, changed to -1. Since the error reason is not only the number mismatch, for better visibility in the logs, returning error here.
| Expect(input.ClusterProxy).ToNot(BeNil(), "Invalid argument. input.ClusterProxy can't be nil when calling ScaleAndWaitMachineDeployment") | ||
| Expect(input.Cluster).ToNot(BeNil(), "Invalid argument. input.Cluster can't be nil when calling ScaleAndWaitMachineDeployment") | ||
|
|
||
| fmt.Fprintf(GinkgoWriter, "Scaling machine deployment %s/%s from %v to %v replicas\n", input.MachineDeployment.Namespace, input.MachineDeployment.Name, input.MachineDeployment.Spec.Replicas, input.Replicas) |
There was a problem hiding this comment.
Using Ginkgo's By might be cleaner here.
There was a problem hiding this comment.
In all new helpers, we log like this. If you think By should be used in all helpers, we should track it in a separate issue.
|
@fabriziopandini I think 3-node upgrade hits timeout but I see you already increased the timeout, I will observe if it fixes. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini, sedefsavas, vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
What this PR does / why we need it:
This PR adds scale helper for machine deployment.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #3015