Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vsphere generate-yaml usability changes, timeout for clusterctl #302

Merged
merged 2 commits into from
Jun 7, 2018
Merged

vsphere generate-yaml usability changes, timeout for clusterctl #302

merged 2 commits into from
Jun 7, 2018

Conversation

karan
Copy link
Contributor

@karan karan commented Jun 7, 2018 •
edited
Loading

What this PR does / why we need it: Change provider config generation a little bit to not overwrite ssh key files in ~/.ssh.

Bump up timeout in clusterctl for various polls.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 7, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: karan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 7, 2018
@karan
Copy link
Contributor Author

karan commented Jun 7, 2018

/assign @jessicaochen

@jessicaochen
Copy link
Contributor

The verbosity improvements are good.

The removal of the copy to the home directory is not functional. The vsphere GetKubeConfig assumes a specific location for the ssh key to use (https://github.com/kubernetes-sigs/cluster-api/blob/master/cloud/vsphere/deployer.go#L60). We need the key to be at that location after generation is done.

We can have sanity check that will not overwite an existing file (unless the overwrite flag is specified) but I think it is non functional to have the deployer break.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 7, 2018
@karan karan changed the title vsphere generate-yaml usability changes vsphere generate-yaml usability changes, timeout for clusterctl Jun 7, 2018
@karan
Copy link
Contributor Author

karan commented Jun 7, 2018

/retest

@karan karan force-pushed the fd branch 2 times, most recently from 907b64d to 98696ad Compare June 7, 2018 18:00
@karan
Copy link
Contributor Author

karan commented Jun 7, 2018

/retest

@jessicaochen
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 7, 2018
@k8s-ci-robot k8s-ci-robot merged commit 982993b into kubernetes-sigs:master Jun 7, 2018
@karan karan deleted the fd branch June 7, 2018 19:19
@karan karan mentioned this pull request Jun 7, 2018
Closed
jayunit100 pushed a commit to jayunit100/cluster-api that referenced this pull request Jan 31, 2020
@karan @k8s-ci-robot
vsphere generate-yaml usability changes, timeout for clusterctl (kube…
9b3f1a7 
…rnetes-sigs#302)

* vsphere generate-yaml usability changes

* Change timeouts, copy ssh keys if they dontexist
jayunit100 pushed a commit to jayunit100/cluster-api that referenced this pull request Jan 31, 2020
@k8s-ci-robot
Merge pull request kubernetes-sigs#302 from andrewsykim/generate-yaml
7f95a1d 
Add better install instructions for envsubst
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jessicaochen jessicaochen

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@karan @k8s-ci-robot @jessicaochen