🐛 KCP should bypass the controller cache when initializing

[vincepri]

Signed-off-by: Vince Prignano [email protected]

What this PR does / why we need it:

This PR adds an uncached client to the KCP reconciler that can be used to talk to the management cluster directly bypassing the internal controller cache. This additional check is only done if the initializeControlPlane method.

In addition to the changes above, this PR also cleans some functions that were accepting client.Client instead of the smaller client.Reader while only doing read operations. This is a backward-compatible change given that the interface is smaller.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #3001

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [vincepri]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[vincepri]

/assign @benmoss @detiber @ncdc
/milestone v0.3.6

[k8s-ci-robot]

@vincepri: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
pull-cluster-api-apidiff	26f5c70	link	/test pull-cluster-api-apidiff

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[dlipovetsky]

Thanks for fixing this, @vincepri!

/lgtm

[jzhoucliqr]

Thanks a lot, @vincepri !