Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛fix a clusterctl error when moving cluster with user provided certs #2988

Merged
merged 1 commit into from
Apr 30, 2020
Merged

🐛fix a clusterctl error when moving cluster with user provided certs #2988

merged 1 commit into from
Apr 30, 2020

Conversation

fabriziopandini
Copy link
Member

What this PR does / why we need it:
This PR fixes an issue in clusterctl when moving clusters with a hyphen in the name and user provider cluster secrets

Which issue(s) this PR fixes:
Fixes #2964

/assign @vincepri
/assign @wfernandes
/cc @Arvinderpal

@k8s-ci-robot
Copy link
Contributor

@fabriziopandini: GitHub didn't allow me to request PR reviews from the following users: Arvinderpal.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

What this PR does / why we need it:
This PR fixes an issue in clusterctl when moving clusters with a hyphen in the name and user provider cluster secrets

Which issue(s) this PR fixes:
Fixes #2964

/assign @vincepri
/assign @wfernandes
/cc @Arvinderpal

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 30, 2020
@fabriziopandini
Copy link
Member Author

@Arvinderpal PTAL

vincepri
vincepri approved these changes Apr 30, 2020
View reviewed changes
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm
/milestone v0.3.5

@k8s-ci-robot k8s-ci-robot added this to the v0.3.5 milestone Apr 30, 2020
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 30, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini, vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [fabriziopandini,vincepri]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 59a696e into kubernetes-sigs:master Apr 30, 2020
@fabriziopandini fabriziopandini deleted the fix-clusterctl-soft-ownership branch May 3, 2020 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincepri vincepri vincepri approved these changes

Assignees

@wfernandes wfernandes

@vincepri vincepri

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v0.3.5
Development

Successfully merging this pull request may close these issues.

[CAPBK] [KCP] [clusterctl] Support moving custom certs
4 participants
@fabriziopandini @k8s-ci-robot @vincepri @wfernandes