🐛 Don't return error if cannot find default config #2951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/M
wfernandes
commented
Apr 22, 2020
neolit123
reviewed
Apr 22, 2020
|
/assign @fabriziopandini |
wfernandes
force-pushed
the
fix-config-error
branch
from
f94809d to
11e0d6f
Compare
There was a problem hiding this comment.
@wfernandes thanks for fixing this!
just a question to see if we can avoid the workaround for spf13/viper#900 ...
wfernandes
force-pushed
the
fix-config-error
branch
2 times, most recently
from
73889aa to
9aae26a
Compare
vincepri
reviewed
Apr 23, 2020
wfernandes
force-pushed
the
fix-config-error
branch
from
9aae26a to
a2848eb
Compare
k8s-ci-robot
added
size/L
jdef
reviewed
Apr 23, 2020
If clusterctl default config under $HOME/.cluster-api/clusterctl.yaml doesn't exist, commands like clusterctl init should still work. However, it should still return errors if the contents of the config file is unparsable. If no path is specified and if there is no default config available, just skip reading in the config
wfernandes
force-pushed
the
fix-config-error
branch
from
a2848eb to
13272a8
Compare
fabriziopandini
approved these changes
Apr 24, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini, wfernandes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/milestone v0.3.4 |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
If clusterctl default config under $HOME/.cluster-api/clusterctl.yaml
doesn't exist, commands like clusterctl init should still work.
However, it should still return errors if the contents of the config file is unparsable.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #2947