🏃‍♂️ Remove cmd/clusterctl/test folder

[prankul88]

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #2930

[prankul88]

@fabriziopandini Deleting this folder would also delete the go.mod and go.sum files which are used by make modules command. Should I move these 2 files to test/e2e folder and add an option of make modules in the Makefile there?

[vincepri]

/assign @fabriziopandini

[fabriziopandini]

/test pull-cluster-api-e2e

[fabriziopandini]

@prankul88 thanks!
I think you should run make modules to get the verify check to pass

[prankul88]

@fabriziopandini make modules fail due to missing CLUSTERCTL_E2E_DIR

cluster-api/Makefile

Line 326 in ba3bd5c

$(MAKE) -C $(CLUSTERCTL_E2E_DIR) modules

[fabriziopandini]

@prankul88 you can drop this line and the declaration of the CLUSTERCTL_E2E_DIR variable

[prankul88]

@fabriziopandini PTAL

[k8s-ci-robot]

@prankul88: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
pull-cluster-api-capd-e2e	ac8927b	link	/test pull-cluster-api-capd-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[fabriziopandini]

/approve

/assign @wfernandes @vincepri
for final lgtm

[vincepri]

/retitle 🏃‍♂️ Remove cmd/clusterctl/test folder
LGTM

[wfernandes]

Reviewing

[wfernandes]

@fabriziopandini I noticed that currently in cmd/clusterctl/test there is a move_test.go which we currently do not have in test/e2e. Is that currently being worked on?

/cc @vincepri @sedefsavas

[sedefsavas]

@wfernandes test/e2e/self_hosted_test.go is testing the move.

[wfernandes]

/lgtm

[ncdc]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini, ncdc, prankul88

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ncdc]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[vincepri]

/milestone v0.3.4