-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🏃[e2e] improve and cleanup e2e clusterctl #2909
🏃[e2e] improve and cleanup e2e clusterctl #2909
Conversation
@@ -1,5 +1,3 @@ | |||
// +build e2e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't we need this? @wfernandes has a different PR that adds this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vincepri @wfernandes
The test framework is basically a library that CAPI is offering to external users, so IMO it should build (and run tests) like any other package
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW I was adding a build tag to docker/e2e/custom_management.go
If we remove the build tag, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/milestone v0.3.4
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini, vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
What this PR does / why we need it:
This PR implements a set of small improvements and cleanup to the e2e clusterctl package:
+build e2e
tag (not required in the framework)LogPath
/LogFolder
variable naming (now it is used consistentlyLogFolder
)config.Validate
into two smaller functions (fixes a linter check)config
typeWhich issue(s) this PR fixes:
xref #2753
xref #2637
xref #2636
/assign @vincepri
/assign @sedefsavas