Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🏃[e2e]: add namespace utils to the test framework #2891

Merged

Conversation

fabriziopandini
Copy link
Member

What this PR does / why we need it:
This PR introduces utilities to the E2E framework to be used for running each test spec in a dedicated namespace on the management cluster:

  • create namespace
  • stream namespace events to a log file
  • delete namespace

Which issue(s) this PR fixes:
xref #2753
xref #2637
xref #2636

/assign @vincepri
/assign @sedefsavas

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 10, 2020
@k8s-ci-robot k8s-ci-robot requested review from justinsb and ncdc April 10, 2020 10:20
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 10, 2020
// CreateNamespaceInput is the input type for CreateNamespace.
type CreateNamespaceInput struct {
Creator Creator
Name string
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any particular reason to require a Name on input for CreateNamespace?

Could you make Name optional and default to "test-" + util.RandomString(6) if not provided? Otherwise downstream providers consuming this would still have to implement their own randomization.

Copy link
Member

@neolit123 neolit123 Apr 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

informatively, the k/k framework:

  • (in the default Before function)
  • takes the test name as input
  • adds a UUID after the test name
  • loops to make sure a namespace name+uuid does not exist
  • creates the namespace
  • (in the default After function)
  • deletes the namespace

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@detiber Done!
@neolit123 yes, we are following a similar path

test/framework/management_cluster.go Show resolved Hide resolved
test/framework/management_cluster.go Show resolved Hide resolved
test/framework/management_cluster.go Outdated Show resolved Hide resolved
test/framework/management_cluster.go Outdated Show resolved Hide resolved
@fabriziopandini fabriziopandini force-pushed the e2e-add-namespace-utils branch from 293a127 to 5a0a11c Compare April 10, 2020 15:07
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 10, 2020
@fabriziopandini
Copy link
Member Author

@detiber @neolit123 thanks for the feedback!
comment addressed

@ncdc ncdc removed their request for review April 10, 2020 15:11
@detiber
Copy link
Member

detiber commented Apr 10, 2020

@fabriziopandini thanks! lgtm

@sedefsavas
Copy link

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 10, 2020
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@vincepri
Copy link
Member

/milestone v0.3.4

@k8s-ci-robot k8s-ci-robot added this to the v0.3.4 milestone Apr 10, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini, vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 10, 2020
@k8s-ci-robot k8s-ci-robot merged commit 19121e7 into kubernetes-sigs:master Apr 10, 2020
@fabriziopandini fabriziopandini deleted the e2e-add-namespace-utils branch April 11, 2020 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants