-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🏃[e2e]: add namespace utils to the test framework #2891
🏃[e2e]: add namespace utils to the test framework #2891
Conversation
// CreateNamespaceInput is the input type for CreateNamespace. | ||
type CreateNamespaceInput struct { | ||
Creator Creator | ||
Name string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any particular reason to require a Name
on input for CreateNamespace?
Could you make Name
optional and default to "test-" + util.RandomString(6)
if not provided? Otherwise downstream providers consuming this would still have to implement their own randomization.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
informatively, the k/k framework:
- (in the default Before function)
- takes the test name as input
- adds a UUID after the test name
- loops to make sure a namespace name+uuid does not exist
- creates the namespace
- (in the default After function)
- deletes the namespace
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@detiber Done!
@neolit123 yes, we are following a similar path
293a127
to
5a0a11c
Compare
@detiber @neolit123 thanks for the feedback! |
@fabriziopandini thanks! lgtm |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/milestone v0.3.4 |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini, vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
This PR introduces utilities to the E2E framework to be used for running each test spec in a dedicated namespace on the management cluster:
Which issue(s) this PR fixes:
xref #2753
xref #2637
xref #2636
/assign @vincepri
/assign @sedefsavas