🐛 Correctly sets DNS imageRepository when custom repositories are used

[gab-satchi]

Which issue(s) this PR fixes
Fixes #2810

[vincepri]

Overall this is a good step, although I wonder if we can find / build a regular expression and validate each input?

Maybe @randomvariable knows where can get a good regex to parse OCI images? Then we can use the regexp package to divide the incoming string in groups and return what we need

[vincepri]

In alternative, if we can't find a good regex with groups, we can use the reference repository we're using today just for validation / normalization, then parse the strings manually where required

[gab-satchi]

Agree with the potential of panics. That was going through my head when working on this as well. My regex-fu isn't that good but I think the reference library uses them as well. So might just be able to get it from there.

[randomvariable]

The reference library has a bunch of regexes at https://github.com/docker/distribution/blob/master/reference/regexp.go

[vincepri]

For this iteration, I'd suggest to build these higher level functions on top of the reference library, but make them work like we need.

[gab-satchi]

@vincepri updated to just use the constant in the file that's used to search for the deployment.

[vincepri]

code changes lgtm, should we retitle the PR and tackle the image library separately?

[gab-satchi]

/retitle Correctly sets DNS imageRepository when custom repositories are used

[ncdc]

/lgtm

[vincepri]

/milestone v0.3.4

[vincepri]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gab-satchi, vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [vincepri]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment