🏃[e2e] clusterctl e2e discovery #2820
Conversation
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini, vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
test/framework/controllers.go
Outdated
|
|
||
| // WaitForDeploymentsAvailable waits until the Deployment has status.Available = True, that signals that | ||
| // all the desired replicas are in place. | ||
| func WaitForDeploymentsAvailable(ctx context.Context, input WaitForDeploymentsAvailableInput, intervals ...interface{}) { |
There was a problem hiding this comment.
nit. We can combine this with framework/workload_cluster.go
There was a problem hiding this comment.
I moved to framework/management_cluster.go which seems more appropriate, but the result is the same (no more controller.go file)
| } | ||
|
|
||
| // GetKubeadmControlPlaneByCluster returns the KubeadmControlPlane objects for a cluster. | ||
| // Important! this method relies on labels that are created by the CAPI controllers during the first reconciliation, so |
There was a problem hiding this comment.
Can this rely on the owner ref, instead of labels?
There was a problem hiding this comment.
AFAIK ownerRef can't be used as a filter option for List.
Additionally, also ownerRef are set by CPAI controller during first reconciliation, so the same note will apply no matter of the change
fabriziopandini
force-pushed
the
add-clusterctl-e2e-discovery
branch
from
9418e1f to
bbf11a9
Compare
|
@sedefsavas thanks for the feedback. comments addressed/answer provided |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
| } | ||
| return false | ||
|
|
||
| }, intervals...).Should(BeTrue(), "Deployment %s/%s failed to get status.Available = True condition") |
There was a problem hiding this comment.
Should this have been a fmt.Sprintf("Deployment %s/%s failed to get status.Available = True condition", input.Deployment.GetNamespace(), input.Deployment.GetName())
There was a problem hiding this comment.
@wfernandes good catch!
fixed by #2864
What this PR does / why we need it:
This PR extends the e2e framework by adding the possibility to discover Cluster API objects existing in a management cluster.
This feature allows to:
The PR also includes a utility for waiting for a controller deployment to get ready
Which issue(s) this PR fixes:
xref #2753
xref #2637
xref #2636
/assign @vincepri
/assign @sedefsavas
/cc @wfernandes
/cc @gab-satchi