Make delete node work for vsphere #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: karan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
|
/assign @kcoronado |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
spew
reviewed
Jun 5, 2018
|
|
||
| // The machine HCL reads the startup script, so we need to have something there for terraform | ||
| // to not fail. | ||
| if err := saveFile("", path.Join("/tmp", "machine-startup.sh"), 0644); err != nil { |
There was a problem hiding this comment.
It would be better to use a library driven temporary location so on systems where tmp is not a /tmp this code will not error, i.e. ioutil.TempFile(...):
jayunit100
pushed a commit
to jayunit100/cluster-api
that referenced
this pull request
Jan 31, 2020
jayunit100
pushed a commit
to jayunit100/cluster-api
that referenced
this pull request
Jan 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: Make delete work since moving to tfstate-in-machine-object model.
Which issue(s) this PR fixes:
Fixes #281
I have tested this change.