📖 Add intial Spot instances proposal #2817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
vincepri
approved these changes
Apr 14, 2020
There was a problem hiding this comment.
/approve
/assign @enxebre @vincepri @detiber @ncdc @CecileRobertMichon @randomvariable
k8s-ci-robot
assigned CecileRobertMichon, detiber, enxebre, ncdc, randomvariable and vincepri
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoelSpeed, vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
+1 from my side to get this work started. |
|
/hold |
k8s-ci-robot
added
do-not-merge/hold
|
thanks @JoelSpeed |
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Based off of the google doc proposal that was shared at the end of February, I have created this proposal doc based off of the template explaining how Spot instances should be implemented across the three cloud providers; AWS, Azure, GCP.
Note, this proposal does not change anything within the cluster-api repository itself, but is hosted here so that the implementation of spot support across the cloud providers can be tracked centrally and implemented in a similar manner across each provider. The goal of this project is that support should feel the same in each of the providers.
I think I've included all the people who I discussed this with and gave feedback in the reviewers list, let me know if anyone else should be added