🏃clusterctl: add retries to clustectl move #2776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
vincepri
reviewed
Mar 25, 2020
Comment on lines
+235
to
+257
| func newConnectBackoff() wait.Backoff { | ||
| // Return a exponential backoff configuration which returns durations for a total time of ~15s. | ||
| // Example: 0, .25s, .6s, 1.2, 2.1s, 3.4s, 5.5s, 8s, 12s | ||
| // Jitter is added as a random fraction of the duration multiplied by the jitter factor. | ||
| return wait.Backoff{ | ||
| Duration: 250 * time.Millisecond, | ||
| Factor: 1.5, | ||
| Steps: 9, | ||
| Jitter: 0.1, | ||
| } | ||
| } | ||
|
|
||
| // newReadBackoff creates a new API Machinery backoff parameter set suitable for use with clusterctl read operations. | ||
| func newReadBackoff() wait.Backoff { | ||
| // Return a exponential backoff configuration which returns durations for a total time of ~15s. | ||
| // Example: 0, .25s, .6s, 1.2, 2.1s, 3.4s, 5.5s, 8s, 12s | ||
| // Jitter is added as a random fraction of the duration multiplied by the jitter factor. | ||
| return wait.Backoff{ | ||
| Duration: 250 * time.Millisecond, | ||
| Factor: 1.5, | ||
| Steps: 9, | ||
| Jitter: 0.1, | ||
| } |
There was a problem hiding this comment.
these two seem to have effectively the same values, is that intended?
There was a problem hiding this comment.
yes, I do expect some tuning here.
|
@vincepri comment addressed (in a separated commit for easier review) |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
fabriziopandini
force-pushed
the
clusterctl-add-retries
branch
from
b56f297 to
b8026b3
Compare
k8s-ci-robot
removed
the
lgtm
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
|
/lgtm |
|
/milestone v0.3.3 |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR add some more retries to clusterctl. More specifically
/assign @vincepri
/assign @wfernandes