🏃[e2e] enable all docker e2e tests for CI

[sedefsavas]

What this PR does / why we need it:
This PR enables an existing e2e test that does KCP upgrade for CI.
Also, timeout is increased as it takes longer than 3 minutes in local setups.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #2654

[sedefsavas]

Full e2e test is currently giving this error after creating the first upgraded machine: "failed to pick control plane Machine to mark for deletion"

/hold until figuring out the issue with that.

cc @wfernandes @vincepri

[sedefsavas]

I am suspecting CAPD is missing out some changes that happened in other providers about adding machines to failure domains, so that when KCP is trying to pick a machine to delete during upgrade here:

cluster-api/controlplane/kubeadm/controllers/kubeadm_control_plane_controller.go

Line 516 in ba22259

fd := controlPlane.FailureDomainWithMostMachines()

getting this error:
E0323 20:29:57.393552 1 controller.go:258] controller-runtime/controller "msg"="Reconciler error" "error"="failed to pick control plane Machine to mark for deletion" "controller"="kubeadmcontrolplane" "request"={"Namespace":"default","Name":"test-0"}

[sedefsavas]

can we merge this? @vincepri @wfernandes

[sedefsavas]

/hold cancel

[wfernandes]

/lgtm

[vincepri]

might want to rebase to see capd-e2e pass?

[wfernandes]

Since this is removing the FOCUS, I'll run it locally and see if Full Upgrade test passes as well.

[wfernandes]

/lgtm cancel
So the Full Upgrade test failed on my machine. In order to avoid CI test failures I suggest we hold off on merging this in until we get this consistently passing locally.

[sedefsavas]

@wfernandes Can you post the error you are seeing in KCP when it fails on your local?
Because the machine selection is merged, that was supposed to fix the issue.

[sedefsavas]

/retest

[wfernandes]

@sedefsavas I'm going to run make test-capd-e2e-full to enusre everything is running. But I get the same timeout error as the pull-cluster-api-capd-e2e. I'll try and grab the KCP logs whilst it is running.

[sedefsavas]

/retest

[sedefsavas]

It is working with the latest changes. Do you think we can merge this?
@wfernandes @vincepri

[sedefsavas]

/retest

[wfernandes]

/lgtm

[vincepri]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sedefsavas, vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• test/infrastructure/docker/OWNERS [vincepri]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment