🐛 KCP should set a timeout when trying to connect to remote cluster #2708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
vincepri
reviewed
Mar 18, 2020
vincepri
reviewed
Mar 18, 2020
| reterr = kerrors.NewAggregate([]error{reterr, err}) | ||
|
|
||
| // If we don't have a DeletionTimestamp set, we try to update status | ||
| if kcp.ObjectMeta.DeletionTimestamp.IsZero() { |
There was a problem hiding this comment.
I'd move this check inside updateStatus on 325-ish, right before GetWorkloadCluster call
Signed-off-by: Vince Prignano <[email protected]>
vincepri
changed the title
|
/milestone v0.3.2 |
|
This should be ready to go |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: frapposelli, vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds a restConfig timeout to 10 seconds to avoid getting stuck when deleting a self-managed cluster
Fixes #2705