🏃cmd-clusterctl-client-repository/test: standardize gomega imports

[cpanato]

What this PR does / why we need it:
standardize gomega imports for cmd/clusterctl/client/repository/** tests
will open other PR for the other folders to make easier the review

/cc @vincepri @detiber

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Related to #2433

[vincepri]

/milestone v0.3.1
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• cmd/clusterctl/OWNERS [vincepri]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[cpanato]

thanks for your review again @detiber. PTAL 😄

[fabriziopandini]

/hold
As far as I understand the issue, the request was to standardize existing ginko/gomega imports, not to convert everything to use ginko/gomega
@chuckha @vincepri ^^

[chuckha]

/hold
As far as I understand the issue, the request was to standardize existing ginko/gomega imports, not to convert everything to use ginko/gomega
@chuckha @vincepri ^^

I agree, we should open an issue to discuss if ginkgo style tests are the standard we want to enforce int his repository.

The original issue was to standardize on how to import ginkgo/gomega, not how to write tests.

[vincepri]

@chuckha @fabriziopandini I was under the impression we were doing the latter, converting the tests and providing a guideline for future tests. I'm 👍 proceeding with this effort, it's a great way to enforce a standard going forward and prioritize readability before everything else.

[fabriziopandini]

/hold cancel

[detiber]

/lgtm