Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update quick start guide for flow and update parameters for AWS, Azure and vSphere #2628

Merged
merged 1 commit into from
Mar 12, 2020
Merged

Update quick start guide for flow and update parameters for AWS, Azure and vSphere #2628

merged 1 commit into from
Mar 12, 2020

Conversation

randomvariable
Copy link
Member

@randomvariable randomvariable commented Mar 10, 2020 •
edited
Loading

Signed-off-by: Naadir Jeewa [email protected]

What this PR does / why we need it:
Matches exposed parameters in the templates for AWS and vSphere, and consolidates the quick start documentation

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #2601

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 10, 2020
detiber
detiber reviewed Mar 10, 2020
View reviewed changes
Copy link
Member

@detiber detiber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question around separating out provider vars vs workload cluster vars, otherwise lgtm

docs/book/src/tasks/installation.md Outdated Show resolved Hide resolved
@randomvariable randomvariable force-pushed the capa-capv-doc-updates branch 2 times, most recently from 228c750 to 899d964 Compare March 11, 2020 11:40
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 11, 2020
@randomvariable randomvariable changed the title Update quick start parameters for AWS and vSphere Update quick start guide for flow and update parameters AWS, Azure and vSphere Mar 11, 2020
@randomvariable randomvariable changed the title Update quick start guide for flow and update parameters AWS, Azure and vSphere Update quick start guide for flow and update parameters for AWS, Azure and vSphere Mar 11, 2020
@randomvariable randomvariable mentioned this pull request Mar 11, 2020
Merged
detiber
detiber reviewed Mar 11, 2020
View reviewed changes
docs/book/src/user/quick-start.md Outdated Show resolved Hide resolved
docs/book/src/user/quick-start.md Show resolved Hide resolved
@randomvariable randomvariable force-pushed the capa-capv-doc-updates branch from 020b46c to 8f69b10 Compare March 11, 2020 21:27
@randomvariable
Copy link
Member Author

Included the two changes

@detiber
Copy link
Member

detiber commented Mar 11, 2020

/lgtm
/assign @vincepri

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 11, 2020
@randomvariable randomvariable force-pushed the capa-capv-doc-updates branch from 8f69b10 to 450cda0 Compare March 11, 2020 22:12
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 11, 2020
@randomvariable randomvariable mentioned this pull request Mar 11, 2020
Closed
@randomvariable randomvariable force-pushed the capa-capv-doc-updates branch from 450cda0 to dbe8895 Compare March 12, 2020 09:56
@prankul88
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 12, 2020
vincepri
vincepri approved these changes Mar 12, 2020
View reviewed changes
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@vincepri
Copy link
Member

/milestone v0.3.1

@k8s-ci-robot k8s-ci-robot added this to the v0.3.1 milestone Mar 12, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: randomvariable, vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 12, 2020
@k8s-ci-robot k8s-ci-robot merged commit 5bb2219 into kubernetes-sigs:master Mar 12, 2020
@randomvariable randomvariable deleted the capa-capv-doc-updates branch March 12, 2020 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prankul88 prankul88 prankul88 left review comments

@detiber detiber detiber left review comments

@vincepri vincepri vincepri approved these changes

@CecileRobertMichon CecileRobertMichon Awaiting requested review from CecileRobertMichon

@moshloop moshloop Awaiting requested review from moshloop

Assignees

@detiber detiber

@vincepri vincepri

@prankul88 prankul88

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
v0.3.1
Development

Successfully merging this pull request may close these issues.

Docs: evaluate if possible to remove install.md
5 participants
@randomvariable @detiber @prankul88 @vincepri @k8s-ci-robot