Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🏃 bootstrap/tests: standardize gomega imports - follow up #2614

Merged
merged 1 commit into from
Mar 11, 2020
Merged

🏃 bootstrap/tests: standardize gomega imports - follow up #2614

merged 1 commit into from
Mar 11, 2020

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Mar 10, 2020 •
edited
Loading

What this PR does / why we need it:
standardize gomega imports for bootstrap/**/*** test

will open other PR for the other folders to make easier the review

/cc @vincepri

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Related to #2433

@k8s-ci-robot k8s-ci-robot requested a review from vincepri March 10, 2020 14:17
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 10, 2020
chuckha
chuckha approved these changes Mar 10, 2020
View reviewed changes
Copy link
Contributor

@chuckha chuckha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

/assign @vincepri

I think there are some different expectations (such as g.Equal() instead of reflect.DeepEqual()) to use to make this read a little cleaner, but I think that can get cleaned up later and isn't necessary to add in these series of PRs.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chuckha, cpanato

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 10, 2020
detiber
detiber reviewed Mar 10, 2020
View reviewed changes
bootstrap/kubeadm/internal/cloudinit/cloudinit_test.go Outdated Show resolved Hide resolved
bootstrap/kubeadm/internal/cloudinit/cloudinit_test.go Outdated Show resolved Hide resolved
bootstrap/kubeadm/types/v1beta1/bootstraptokenstring_test.go Outdated Show resolved Hide resolved
bootstrap/kubeadm/types/v1beta1/bootstraptokenstring_test.go Outdated Show resolved Hide resolved
bootstrap/kubeadm/types/v1beta1/bootstraptokenstring_test.go Outdated Show resolved Hide resolved
bootstrap/kubeadm/types/v1beta2/bootstraptokenstring_test.go Outdated Show resolved Hide resolved
bootstrap/kubeadm/types/v1beta2/bootstraptokenstring_test.go Outdated Show resolved Hide resolved
bootstrap/kubeadm/types/v1beta2/bootstraptokenstring_test.go Outdated Show resolved Hide resolved
bootstrap/kubeadm/types/v1beta2/bootstraptokenstring_test.go Outdated Show resolved Hide resolved
bootstrap/kubeadm/types/v1beta2/bootstraptokenstring_test.go Outdated Show resolved Hide resolved
@cpanato
Copy link
Member Author

cpanato commented Mar 10, 2020 •
edited
Loading

@detiber @chuckha thanks for your review, really appreciate and learned new things about gomega :)
PTAL

@vincepri
Copy link
Member

/milestone v0.3.x

@k8s-ci-robot k8s-ci-robot added this to the v0.3.x milestone Mar 10, 2020
@detiber
Copy link
Member

detiber commented Mar 10, 2020

lgtm, once v0.3.0 release has been cut and branch is open for merging v0.3.x PRs :)

@cpanato
Copy link
Member Author

cpanato commented Mar 11, 2020

/assign @vincepri

vincepri
vincepri approved these changes Mar 11, 2020
View reviewed changes
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/milestone v0.3.1
/lgtm

@k8s-ci-robot k8s-ci-robot modified the milestones: v0.3.x, v0.3.1 Mar 11, 2020
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 11, 2020
@k8s-ci-robot k8s-ci-robot merged commit 5426006 into kubernetes-sigs:master Mar 11, 2020
@cpanato cpanato deleted the GH-2433-3 branch March 11, 2020 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@detiber detiber detiber left review comments

@vincepri vincepri vincepri approved these changes

@chuckha chuckha chuckha approved these changes

Assignees

@vincepri vincepri

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v0.3.1
Development

Successfully merging this pull request may close these issues.
5 participants
@cpanato @k8s-ci-robot @vincepri @detiber @chuckha