🏃 Remove private APIs from Kubeadm v1beta1 types #2605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/test pull-cluster-api-test |
|
wondering why this is failing now ^ |
|
this looks good to me Was there a particular reason for changing the generated code? |
|
Without it, it'd fail compilation because we removed the field, I only added the paths to the Makefile, because we use controller-gen the generated files are slightly different but with same functionality |
|
LGTM. Ready to merge? |
|
Ready for me! |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
vincepri
force-pushed
the
cleanup-kubeadm-private-api
branch
from
185271e to
899357e
Compare
k8s-ci-robot
removed
the
lgtm
Signed-off-by: Vince Prignano <[email protected]>
vincepri
force-pushed
the
cleanup-kubeadm-private-api
branch
from
899357e to
cd602ce
Compare
k8s-ci-robot
added
size/L
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vince Prignano [email protected]
What this PR does / why we need it:
Context: https://kubernetes.slack.com/archives/C8TSNPY4T/p1583780405249500
/milestone v0.3.0
/assign @ncdc @fabriziopandini