🐛 Fix CAPD Calico manifest URL #2564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
/lgtm think it's reasonable we get signal on newer releases of Calico. |
k8s-ci-robot
added
the
lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoelSpeed, ncdc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Calico have removed the
v3.12hosted version of their docs (the link 404s) and now the CAPD tests are failing because the file they're downloading is not valid YAMLI've quickly verified and calico currently seem to host the calico manifest at three locations:
manifests/calico.yaml(this matches the current latest release)v3.13/manifests/calico.yamlmaster/manifests/calico.yamlIf we use a specific release, it's likely this test is going to break regularly as they create new releases, I propose we use the naked
manifests/calico.yamlas it should always match the latest release and should be stableI suspect this got broken with this projectcalico/calico@5ba055a