🏃 continue improving management/workload abstraction

[chuckha]

Signed-off-by: Chuck Ha [email protected]

What this PR does / why we need it:
This is in order to help #2525 test with way less pain and abstraction layer violations.

The big changes here are:

1. Define the management cluster interface -> this work is incomplete as the reconciler still directly interfaces with the client, but this work can be done in future PRs
2. Define the workload cluster interface -> This allows us to more closely unit test the reconciler and control the behavior of various sub-systems.
3. Inlining of several functions as they were only single use, not complex, not independently tested and short
4. Refactored the Cluster struct to a more useful name, Workload and updated receivers.

/cc @alexander-demichev @dlipovetsky
/assign @detiber

[k8s-ci-robot]

@chuckha: GitHub didn't allow me to request PR reviews from the following users: alexander-demichev.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

Signed-off-by: Chuck Ha [email protected]

What this PR does / why we need it:
This is in order to help #2525 test with way less pain and abstraction layer violations.

The big changes here are:

1. Define the management cluster interface -> this work is incomplete as the reconciler still directly interfaces with the client, but this work can be done in future PRs
2. Define the workload cluster interface -> This allows us to more closely unit test the reconciler and control the behavior of various sub-systems.
3. Inlining of several functions as they were only single use, not complex, not independently tested and short
4. Refactored the Cluster struct to a more useful name, Workload and updated receivers.

/cc @alexander-demichev @dlipovetsky
/assign @detiber

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chuckha

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [chuckha]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[vincepri]

/milestone v0.3.0
/lgtm

[vincepri]

/hold

for other reviewers

[detiber]

lgtm as well

[chuckha]

once the capd fix merges i'm going to rerun them here and unhold

[chuckha]

/test pull-cluster-api-capd-e2e

[chuckha]

/hold cancel