Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🏃Disable Interfacer Linter #2511

Merged
merged 1 commit into from
Mar 3, 2020

Conversation

JoelSpeed
Copy link
Contributor

What this PR does / why we need it:

This PR disables the Interfacer linter which has been deprecated and is currently blocking #2494 from merging

/cc @ncdc

@k8s-ci-robot k8s-ci-robot requested a review from ncdc March 3, 2020 15:57
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 3, 2020
@ncdc
Copy link
Contributor

ncdc commented Mar 3, 2020

Thanks!

/kind cleanup
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Mar 3, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed, ncdc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 3, 2020
@vincepri
Copy link
Member

vincepri commented Mar 3, 2020

/milestone v0.3.0-rc.3

@k8s-ci-robot k8s-ci-robot added this to the v0.3.0-rc.3 milestone Mar 3, 2020
@k8s-ci-robot k8s-ci-robot merged commit f65d4ae into kubernetes-sigs:master Mar 3, 2020
@JoelSpeed JoelSpeed deleted the disable-interfacer branch March 3, 2020 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants