-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix SSH issue with in place upgrades. #247
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: k4leung4 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/assign @karan @jessicaochen |
did you try |
added that option to ssh as well. |
The master in-place upgrade is currently broken due to an SSH failure with the error "Host key verification failed." As the master machine may change, it should be safe to disable the host key check, which fixes the issue.
/unassign @jessicaochen /assign @medinatiger |
Verified in-place upgrades works. |
Does that mean the control plane works after the upgrade, or only that the image was upgraded? |
Both, was able to upgrade control plane from 1.9.4 to 1.9.7, and the master is responsive after the upgrade, verified by running kubectl get machines |
Sweet. /lgtm |
…eriod Made SyncPeriod configurable
What this PR does / why we need it:
The master in-place upgrade is currently broken due to an SSH failure
with the error "Host key verification failed."
As the master machine may change, it should be safe to disable the host
key check, which fixes the issue.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #182
Special notes for your reviewer:
Release note:
@kubernetes/kube-deploy-reviewers