Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SSH issue with in place upgrades. #247

Merged
merged 1 commit into from
Jun 1, 2018

Conversation

k4leung4
Copy link
Contributor

What this PR does / why we need it:
The master in-place upgrade is currently broken due to an SSH failure
with the error "Host key verification failed."
As the master machine may change, it should be safe to disable the host
key check, which fixes the issue.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #182

Special notes for your reviewer:

Release note:


@kubernetes/kube-deploy-reviewers

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: k4leung4

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 30, 2018
@k4leung4
Copy link
Contributor Author

/assign @karan @jessicaochen

@karan
Copy link
Contributor

karan commented May 30, 2018

did you try UserKnownHostsFile=/dev/null along with what you already have?

@k4leung4
Copy link
Contributor Author

added that option to ssh as well.

The master in-place upgrade is currently broken due to an SSH failure
with the error "Host key verification failed."
As the master machine may change, it should be safe to disable the host
key check, which fixes the issue.
@k4leung4
Copy link
Contributor Author

/unassign @jessicaochen

/assign @medinatiger

@k4leung4
Copy link
Contributor Author

k4leung4 commented Jun 1, 2018

Verified in-place upgrades works.

@karan
Copy link
Contributor

karan commented Jun 1, 2018

Does that mean the control plane works after the upgrade, or only that the image was upgraded?

@k4leung4
Copy link
Contributor Author

k4leung4 commented Jun 1, 2018

Both, was able to upgrade control plane from 1.9.4 to 1.9.7, and the master is responsive after the upgrade, verified by running kubectl get machines

@karan
Copy link
Contributor

karan commented Jun 1, 2018

Sweet.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 1, 2018
@k8s-ci-robot k8s-ci-robot merged commit 1f11e62 into kubernetes-sigs:master Jun 1, 2018
chuckha pushed a commit to chuckha/cluster-api that referenced this pull request Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GCP Update controlPlane Version Fails
5 participants