Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize location of AddCommand(...) call #228

Merged
merged 1 commit into from
May 29, 2018

Conversation

spew
Copy link
Contributor

@spew spew commented May 29, 2018

All AddCommand(...) calls are now made from the sub-command which adds itself to its root / parent command.

What this PR does / why we need it:
This PR standardizes the location of the AddCommand call to reduce confusion and make it easier to developers to understand the codebase. The choice was made to add call AddCommand in the sub command's init() method as that matches the examples given on the cobra github README.md.

Release note:

NONE

@kubernetes/kube-deploy-reviewers

All AddCommand(...) calls are now made from the sub-command which adds itself to its root / parent command.
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 29, 2018
@spew
Copy link
Contributor Author

spew commented May 29, 2018

/cc @karan @wangzhen127 @jessicaochen

@k8s-ci-robot
Copy link
Contributor

@spew: GitHub didn't allow me to request PR reviews from the following users: wangzhen127.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @karan @wangzhen127 @jessicaochen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spew
Copy link
Contributor Author

spew commented May 29, 2018

/assign @karan

@karan
Copy link
Contributor

karan commented May 29, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 29, 2018
@k8s-ci-robot k8s-ci-robot merged commit 107e3b3 into kubernetes-sigs:master May 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants