Standardize location of AddCommand(...) call #228
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All AddCommand(...) calls are now made from the sub-command which adds itself to its root / parent command.
What this PR does / why we need it:
This PR standardizes the location of the AddCommand call to reduce confusion and make it easier to developers to understand the codebase. The choice was made to add call AddCommand in the sub command's init() method as that matches the examples given on the cobra github README.md.
Release note:
@kubernetes/kube-deploy-reviewers