-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLUSTER-API-205: Initialize the 'flag' library to remove error message from glog #206
CLUSTER-API-205: Initialize the 'flag' library to remove error message from glog #206
Conversation
…e from glog Prior to this change, every line of logging had the following error message prefixing the actual log: ERROR: logging before flag.Parse This is because glog has a hard dependency on the flag package. This 'hack' serves to make glog happy.
Hi @spew. Thanks for your PR. I'm waiting for a kubernetes or kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @jessicaochen @mkjelland @kcoronado |
/assign @justinsb |
/ok-to-test |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: spew The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✨ Add cluster-api category
🏃 Update Makefile
…ernetes-sigs#206) With kustomize PR 700 merged, in order to avoid attacking, all resources are needed to saved in its sub-folder. So we use the field bases to specify all crds. And in current kustomize code, the commands in secretGenerator is removed, so we use files for replacement.
What this PR does / why we need it:
Prior to this change, every line of logging had the following error message prefixing the actual log:
ERROR: logging before flag.Parse
This is because glog has a hard dependency on the flag package. This 'hack' serves to make glog happy.
Which issue(s) this PR fixes:
Fixes # #205
Special notes for your reviewer:
Tested by running a developer gce-machine-controller image. Below is the before & after for this change.
Before:
After:
Release note:
@kubernetes/kube-deploy-reviewers