-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the meeting times in the README #179
Fix the meeting times in the README #179
Conversation
Hi @staebler. Thanks for your PR. I'm waiting for a kubernetes or kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/assign @jessicaochen @spew |
/assign @k4leung4 |
README.md
Outdated
@@ -17,7 +17,7 @@ To learn more, see the [Cluster API KEP][cluster-api-kep]. | |||
## Get involved! | |||
|
|||
* Join our Cluster API working group sessions | |||
* Weekly on Wednesdays @ 11:00 PT (19:00 UTC) on [Zoom][zoomMeeting] | |||
* Weekly on Wednesdays @ 10:00 PDT (17:00 UTC) on [Zoom][zoomMeeting] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this something we plan to change everytime we switch between pdt/pst?
the time should be 10:00, but should the time zone be just PT to say it is applies whether it is daylight savings or not?
not sure how we would make utc indifferent to daylight savings.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kenny are you saying that we switched the meeting time in Seattle from 11:00 to 10:00 as a result of daylight savings time changes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The concern is around changing PT to PDT and the correct UTC time is dependent on whether it is PDT or PST.
The UTC time will be incorrect whenever PDT changes to PST
10:00 PDT is 17:00 UTC
10:00 PST is 18:00 UTC.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello Kenny, I'm more asking about the meeting. Did the meeting time change from 11:00 AM to 10:00 AM or was it always 10:00 AM? If so we should just change it to PST.
And it sounds like that is the point you are making?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to the meeting notes, the meeting time was moved to "10AM PST" starting Dec 20, 2017.
I am just concerned for people using the UTC time, as it does not factor in the daylight savings adjustments.
I would suggest keeping PT or use PDT/PST and note about the UTC being either 17:00 or 18:00 depending on whether daylight savings is being observed or not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No -- because it will inevitably be wrong when we forget to update it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What of "10:00 PT" that needs updating?
I'm not sure what was the original reason for changing the meeting time, but I don't think it was due to daylight savings, or was it?
@roberthbailey can you comment on whether the changing of the meeting time was due to daylight savings or not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From the definition of PT via google:
PDT = Pacific Daylight Time = fixed to UTC-7. PST = Pacific Standard Time = fixed to UTC-8. PT = Pacific Time = a general reference to the time zone, which alternates between PDT and PST depending on the time of year.
IF the meeting is bound to PT, then sure, that is a better choice. I wasn't thinking that was the case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is the question. As the original time listed is PT, and we kept the 10AM PT time before and after daylight savings began this year, it would seem we are bound to PT.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Like most sig meetings, the meeting is fixed in pacific time, not UTC time. So PT is more accurate that PST or PDT.
Is there consensus on affixing the time to PT and removing the UTC time?
|
Yes @staebler -- that sounds like the way to go. |
531441a
to
cede5e9
Compare
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: roberthbailey, staebler The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
fix: enable status endpoints
📖Set the manager image patch + release docs
After move to CRD the sync period changed to 10 hrs from few sec Change-Id: Ia845a01df59afa737d26fdd96ded09ea9bd8c9c5 Resolves kubernetes-sigs#179
OCPCLOUD-2257: Use manifests generation tool from provider repo
What this PR does / why we need it:
This PR fixes the meeting times in the README. I missed the meeting today because I relied on the times from the github page being correct.
@kubernetes/kube-deploy-reviewers