Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Add KubeadmControlPlane types / validation webhooks #1765

Merged
merged 2 commits into from
Nov 20, 2019
Merged

✨ Add KubeadmControlPlane types / validation webhooks #1765

merged 2 commits into from
Nov 20, 2019

Conversation

detiber
Copy link
Member

@detiber detiber commented Nov 13, 2019

What this PR does / why we need it:

Initial addition of KubeadmControlPlane types

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Related to #1756

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 13, 2019
@ncdc
Copy link
Contributor

ncdc commented Nov 13, 2019

Isn't this ✨?

@detiber detiber force-pushed the kubeadmControlPlaneTypes branch 2 times, most recently from be597eb to 3e41de6 Compare November 13, 2019 21:11
@detiber
Copy link
Member Author

detiber commented Nov 13, 2019

Isn't this ✨ ?

I haven't made the other type changes yet.

@vincepri
Copy link
Member

/milestone v0.3.0

@k8s-ci-robot k8s-ci-robot added this to the v0.3.0 milestone Nov 14, 2019
@detiber detiber force-pushed the kubeadmControlPlaneTypes branch 2 times, most recently from eb30d26 to ffa5470 Compare November 14, 2019 16:08
@chuckha chuckha mentioned this pull request Nov 14, 2019
Closed
33 tasks
@chuckha
Copy link
Contributor

chuckha commented Nov 14, 2019

It would be really great to add some kind of documentation for the new types so that as we need to keep stuff documented the pages already exist and have a little bit of information already. Absolutely fine to have a warning saying these types are a work in progress use at your own risk etc etc

@detiber detiber force-pushed the kubeadmControlPlaneTypes branch 2 times, most recently from e832072 to ca33081 Compare November 15, 2019 21:02
@detiber detiber force-pushed the kubeadmControlPlaneTypes branch from 82bd57a to 09d8383 Compare November 19, 2019 23:34
@vincepri vincepri changed the title [WIP] ⚠️ Add KubeadmControlPlane types [WIP] ⚠️ Add KubeadmControlPlane types / validation webhooks Nov 20, 2019
@detiber detiber force-pushed the kubeadmControlPlaneTypes branch from f9e545d to b11b0d8 Compare November 20, 2019 00:10
@detiber detiber changed the title [WIP] ⚠️ Add KubeadmControlPlane types / validation webhooks ✨ Add KubeadmControlPlane types / validation webhooks Nov 20, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 20, 2019
@detiber
Copy link
Member Author

detiber commented Nov 20, 2019

/assign @ncdc

@ncdc
Copy link
Contributor

ncdc commented Nov 20, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 20, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: detiber, ncdc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ncdc
ncdc reviewed Nov 20, 2019
View reviewed changes
main.go
@@ -101,6 +102,10 @@ func main() {
"The amount of time the bootstrap token will be valid",
)

flag.IntVar(&webhookPort, "webhook-port", 9443,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to plumb webhookPort into the manager Options (Port field)

@ncdc
Copy link
Contributor

ncdc commented Nov 20, 2019

/lgtm cancel
(need to fix webhook port)

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 20, 2019
vincepri
vincepri approved these changes Nov 20, 2019
View reviewed changes
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 20, 2019
@k8s-ci-robot k8s-ci-robot merged commit 08b2959 into kubernetes-sigs:master Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noamran noamran noamran left review comments

@ncdc ncdc ncdc left review comments

@vincepri vincepri vincepri approved these changes

@justinsb justinsb Awaiting requested review from justinsb

Assignees

@ncdc ncdc

@vincepri vincepri

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v0.3.0
Development

Successfully merging this pull request may close these issues.
7 participants
@detiber @ncdc @vincepri @chuckha @k8s-ci-robot @jtigger @noamran