[release-1.7] 🌱 clusterctl: always run crd migration if possible to reduce conversion webhook usage #11513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… webhook usage If objects are still stored in the old version, every time an object is requested the kube-apiserver will call the conversion webhook. Instead of lots of conversion webhook calls we once do the migration if possible. Also increases the timeout used for the migrations: Before running CRD migration clusterctl usually upgrades cert-manager which may lead to updating Certificates and rolling out new certificates to our controllers. There is a chance that this can take up to 90s in which conversion, validating or mutatingwebhooks may be unavailable. Because the migration gets run more aggresively during upgrades this also increases the relevant timeouts.
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
do-not-merge/needs-area
|
backporting per #11133 (comment) |
|
/test pull-cluster-api-e2e-release-1-7 |
|
/area clusterctl |
k8s-ci-robot
added
area/clusterctl
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 949f7e38831cbf144ad560bfa5cb904cbfcc7f47
|
|
/approve |
chrischdi
added
the
tide/merge-method-squash
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrischdi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
ah shit, commented on the wrong PR 🙃 |
|
@cahillsf: #11513 failed to apply on top of branch "release-1.9": In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #10513
/assign cahillsf